Added new functionality including song search functionality, added additional search parameters#17
Open
jogoe222 wants to merge 9 commits intolcharlick:masterfrom
Open
Added new functionality including song search functionality, added additional search parameters#17jogoe222 wants to merge 9 commits intolcharlick:masterfrom
jogoe222 wants to merge 9 commits intolcharlick:masterfrom
Conversation
* fix existing doctests * add song search functionality as song_search * add SongResult class for song_search results * add doctests for song_search & SongResult * add method "other" to BandResult to access additional result values
…lease formats, additional notes etc.
…s where there are several bands * fix the genre property to work for collaboration releases where the genres of several bands are listed
YisusChrist
added a commit
to YisusChrist/python-metallum
that referenced
this pull request
Feb 11, 2024
…ch parameters - Added functionality for the song search feature (song_search and SongResult and a change in the link parsing to extract the song ID) - Added additional search parameters for band_search and album_search such as release formats (there's a pull request for this by @pabe-github), additional notes etc. - Integrated the "similar artists" feature from @msanlop's fork and pull request, including the README example - Fixed the requests_cache.core import issue - "Lyrical themes" has since been renamed to just "Themes" - Added an other property to band_search results to allow access to additional search result parameters (issue by me Queries resulting in more than just the basic band information lcharlick#7) Original pull request: lcharlick#17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
song_searchandSongResultand a change in the link parsing to extract the song ID)band_searchandalbum_searchsuch as release formats (there's a pull request for this by @pabe-github), additional notes etc.requests_cache.coreimport issueotherproperty toband_searchresults to allow access to additional search result parameters (issue by me Queries resulting in more than just the basic band information #7)